Shaving Bytes on JavaScript Conditionals

By  on  

Whenever you work with JavaScript code, it's as though there's always a shorter way to code something.  You thought that a code set was basic until you found out that something was basic...er.  One of those code shortcuts can be found with conditions, specifically short if clauses.

A typical short if clause would look something like this:

if(callback) {
	callback();
}

Oddly enough this conditional can be made shorter:

callback && callback();

The && is less code than the if(){}; of course only by a few characters but does the same job. You could argue that readability suffers but that's up to individual developers.

Recent Features

  • By
    fetch API

    One of the worst kept secrets about AJAX on the web is that the underlying API for it, XMLHttpRequest, wasn't really made for what we've been using it for.  We've done well to create elegant APIs around XHR but we know we can do better.  Our effort to...

  • By
    Page Visibility API

    One event that's always been lacking within the document is a signal for when the user is looking at a given tab, or another tab. When does the user switch off our site to look at something else? When do they come back?

Incredible Demos

  • By
    9 Mind-Blowing Canvas Demos

    The <canvas> element has been a revelation for the visual experts among our ranks.  Canvas provides the means for incredible and efficient animations with the added bonus of no Flash; these developers can flash their awesome JavaScript skills instead.  Here are nine unbelievable canvas demos that...

  • By
    Create a Dynamic Flickr Image Search with the Dojo Toolkit

    The Dojo Toolkit is a treasure chest of great JavaScript classes.  You can find basic JavaScript functionality classes for AJAX, node manipulation, animations, and the like within Dojo.  You can find elegant, functional UI widgets like DropDown Menus, tabbed interfaces, and form element replacements within...

Discussion

  1. It’s worth noting that JS minifiers like Google’s Closure Compiler will do this for you, so the first option is probably better so you get the readability without sacrificing performance. The Closure Compiler outputs it as this:

    callback&&callback();

    http://closure-compiler.appspot.com/home

  2. Herbut

    and also jshint might shout about the shorter version (depending on the settings of course).

  3. It’s bad practice though because the code is hard to maintain, debug and extend. I could write a whole blog on why doing this is bad. I see zero benefits.

  4. Agree with comments above. I recently realized that there is no benefits of having expressions in my code so changed jshint settings and now it disallows to use them.

    IMO the expression below is pretty readable and it also takes one line:
    if (callback) callback();

  5. Agree with the “bad practice” comments.

    Sometimes you seem to post stuff just for the sake of it, or to impress beginners.

    • I appreciate your honesty but impressing people isn’t something that entertains me.

  6. Ana

    What if I also need to have an else branch?

    • There’s only “if”, I suppose. Otherwise it’s something like:

      callback ? callback() : otherThing();
      
  7. While I agree with people’s comments on code readability, I still appreciate posts like this.
    I’ve come across the ‘callback && callback();’ syntax before and had to look up wtf was going on. Had I read this post earlier, I would’ve known :)

  8. Sean

    @Dan i agree with you, posts like this are handy so you understand when you come across it in a project. Sadly, this is clearly lost on a couple of the previous commenters who already know everything there is to know.

  9. What setting will make jsHint happy?

  10. Readability is important, but for those who like to hyper-optimize their code, this is a great tip.

Wrap your code in <pre class="{language}"></pre> tags, link to a GitHub gist, JSFiddle fiddle, or CodePen pen to embed!