The Truth About Code Review II
Code review is an essential but sometimes funny part of creating an awesome product or open source project. Of course your project has standards and the developers are all relatively professional, but sometimes developers still don't quite believe in the same coding styles and methodologies. Nothing provides more evidence of that than this code review comic.
Of course sometimes code issues bleed out of methodology issues and into the "hey, this is just crap code" territory. Enter this beautiful comic:
Even if you consider yourself a coding expert, you know you write some crap from time to time. We all look back at older code and cringe. There's nothing wrong with it though -- simply identify, admit, and enhance!
Image from Explosm.net!
![Interview with a Pornhub Web Developer]()
Regardless of your stance on pornography, it would be impossible to deny the massive impact the adult website industry has had on pushing the web forward. From pushing the browser's video limits to pushing ads through WebSocket so ad blockers don't detect them, you have...
![Serving Fonts from CDN]()
For maximum performance, we all know we must put our assets on CDN (another domain). Along with those assets are custom web fonts. Unfortunately custom web fonts via CDN (or any cross-domain font request) don't work in Firefox or Internet Explorer (correctly so, by spec) though...
![Detect DOM Node Insertions with JavaScript and CSS Animations]()
I work with an awesome cast of developers at Mozilla, and one of them in Daniel Buchner. Daniel's shared with me an awesome strategy for detecting when nodes have been injected into a parent node without using the deprecated DOM Events API.
![Using Dotter for Form Submissions]()
One of the plugins I'm most proud of is Dotter. Dotter allows you to create the typical "Loading..." text without using animated images. I'm often asked what a sample usage of Dotter would be; form submission create the perfect situation. The following...
I was confronted with guys, when I had to figure out why they do not use coding guidelines. They was lucky, that I had not got any green marker :)
Funny thing, I actually wrote something about that last bit you said:
Even if you consider yourself a coding expert, you know you write some crap from time to time. We all look back at older code and cringe. There’s nothing wrong with it though — simply identify, admit, and enhance!
Here’s the link if you’re interested: http://blog.marcomonteiro.net/post/the-six-months-rule
Really nice post thou, simple and to the point.
Interesting.
The WTF should be an international measurement unit.
The problem isn’t writing crap. Your own style change, that’s all. You improve.
The problem is when you feel depressed because your boss told you to rewrite everything, because in that moment you’re not aware of the crap you wrote. Gotta learn fast!
Anyway, I don’t say my past lines of code is “crap”: I just see them as milestones of my coding skill progress :D
HAHA Love this!