The Truth About Code Review II

By  on  

Code review is an essential but sometimes funny part of creating an awesome product or open source project. Of course your project has standards and the developers are all relatively professional, but sometimes developers still don't quite believe in the same coding styles and methodologies. Nothing provides more evidence of that than this code review comic.

Of course sometimes code issues bleed out of methodology issues and into the "hey, this is just crap code" territory. Enter this beautiful comic:

Code Review

Even if you consider yourself a coding expert, you know you write some crap from time to time. We all look back at older code and cringe. There's nothing wrong with it though -- simply identify, admit, and enhance!

Image from Explosm.net!

Recent Features

  • By
    Write Better JavaScript with Promises

    You've probably heard the talk around the water cooler about how promises are the future. All of the cool kids are using them, but you don't see what makes them so special. Can't you just use a callback? What's the big deal? In this article, we'll...

  • By
    5 HTML5 APIs You Didn’t Know Existed

    When you say or read "HTML5", you half expect exotic dancers and unicorns to walk into the room to the tune of "I'm Sexy and I Know It."  Can you blame us though?  We watched the fundamental APIs stagnate for so long that a basic feature...

Incredible Demos

  • By
    MooTools & Printing – Creating a Links Table of Contents

    One detail we sometimes forget when considering print for websites is that the user cannot see the URLs of links when the page prints. While showing link URLs isn't always important, some websites could greatly benefit from doing so. This tutorial will show you...

  • By
    Fullscreen API

    As we move toward more true web applications, our JavaScript APIs are doing their best to keep up.  One very simple but useful new JavaScript API is the Fullscreen API.  The Fullscreen API provides a programmatic way to request fullscreen display from the user, and exit...

Discussion

  1. I was confronted with guys, when I had to figure out why they do not use coding guidelines. They was lucky, that I had not got any green marker :)

  2. Funny thing, I actually wrote something about that last bit you said:

    Even if you consider yourself a coding expert, you know you write some crap from time to time. We all look back at older code and cringe. There’s nothing wrong with it though — simply identify, admit, and enhance!

    Here’s the link if you’re interested: http://blog.marcomonteiro.net/post/the-six-months-rule

    Really nice post thou, simple and to the point.

    • MaxArt

      Interesting.
      The WTF should be an international measurement unit.

  3. MaxArt

    The problem isn’t writing crap. Your own style change, that’s all. You improve.

    The problem is when you feel depressed because your boss told you to rewrite everything, because in that moment you’re not aware of the crap you wrote. Gotta learn fast!

    Anyway, I don’t say my past lines of code is “crap”: I just see them as milestones of my coding skill progress :D

  4. Jake

    HAHA Love this!

Wrap your code in <pre class="{language}"></pre> tags, link to a GitHub gist, JSFiddle fiddle, or CodePen pen to embed!