The Truth About Code Review II
Code review is an essential but sometimes funny part of creating an awesome product or open source project. Of course your project has standards and the developers are all relatively professional, but sometimes developers still don't quite believe in the same coding styles and methodologies. Nothing provides more evidence of that than this code review comic.
Of course sometimes code issues bleed out of methodology issues and into the "hey, this is just crap code" territory. Enter this beautiful comic:
Even if you consider yourself a coding expert, you know you write some crap from time to time. We all look back at older code and cringe. There's nothing wrong with it though -- simply identify, admit, and enhance!
Image from Explosm.net!
![Page Visibility API]()
One event that's always been lacking within the document is a signal for when the user is looking at a given tab, or another tab. When does the user switch off our site to look at something else? When do they come back?
![JavaScript Promise API]()
While synchronous code is easier to follow and debug, async is generally better for performance and flexibility. Why "hold up the show" when you can trigger numerous requests at once and then handle them when each is ready? Promises are becoming a big part of the JavaScript world...
![Editable Content Using MooTools 1.2, PHP, and MySQL]()
Everybody and their aerobics instructor wants to be able to edit their own website these days. And why wouldn't they? I mean, they have a $500 budget, no HTML/CSS experience, and extraordinary expectations. Enough ranting though. Having a website that allows for...
![Use Custom Missing Image Graphics Using Dojo]()
A few months back I posted an article about how you can use your own "missing image" graphics when an image fails to load using MooTools and jQuery. Here's how to do the same using Dojo.
The HTML
We'll delegate the image to display by class...
I was confronted with guys, when I had to figure out why they do not use coding guidelines. They was lucky, that I had not got any green marker :)
Funny thing, I actually wrote something about that last bit you said:
Even if you consider yourself a coding expert, you know you write some crap from time to time. We all look back at older code and cringe. There’s nothing wrong with it though — simply identify, admit, and enhance!
Here’s the link if you’re interested: http://blog.marcomonteiro.net/post/the-six-months-rule
Really nice post thou, simple and to the point.
Interesting.
The WTF should be an international measurement unit.
The problem isn’t writing crap. Your own style change, that’s all. You improve.
The problem is when you feel depressed because your boss told you to rewrite everything, because in that moment you’re not aware of the crap you wrote. Gotta learn fast!
Anyway, I don’t say my past lines of code is “crap”: I just see them as milestones of my coding skill progress :D
HAHA Love this!