The Truth About Code Review II
Code review is an essential but sometimes funny part of creating an awesome product or open source project. Of course your project has standards and the developers are all relatively professional, but sometimes developers still don't quite believe in the same coding styles and methodologies. Nothing provides more evidence of that than this code review comic.
Of course sometimes code issues bleed out of methodology issues and into the "hey, this is just crap code" territory. Enter this beautiful comic:
Even if you consider yourself a coding expert, you know you write some crap from time to time. We all look back at older code and cringe. There's nothing wrong with it though -- simply identify, admit, and enhance!
Image from Explosm.net!
![Designing for Simplicity]()
Before we get started, it's worth me spending a brief moment introducing myself to you. My name is Mark (or @integralist if Twitter happens to be your communication tool of choice) and I currently work for BBC News in London England as a principal engineer/tech...
![9 Mind-Blowing WebGL Demos]()
As much as developers now loathe Flash, we're still playing a bit of catch up to natively duplicate the animation capabilities that Adobe's old technology provided us. Of course we have canvas, an awesome technology, one which I highlighted 9 mind-blowing demos. Another technology available...
![Create a Simple News Scroller Using Dojo]()
My journey into Dojo JavaScript has been exciting and I'm continuing to learn more as I port MooTools scripts to Dojo. My latest experiment is porting a simple new scroller from MooTools to Dojo. The code is very similar!
The HTML
The news items...
![CSS Kwicks]()
One of the effects that made me excited about client side and JavaScript was the Kwicks effect. Take a list of items and react to them accordingly when hovered. Simple, sweet. The effect was originally created with JavaScript but come five years later, our...
I was confronted with guys, when I had to figure out why they do not use coding guidelines. They was lucky, that I had not got any green marker :)
Funny thing, I actually wrote something about that last bit you said:
Even if you consider yourself a coding expert, you know you write some crap from time to time. We all look back at older code and cringe. There’s nothing wrong with it though — simply identify, admit, and enhance!
Here’s the link if you’re interested: http://blog.marcomonteiro.net/post/the-six-months-rule
Really nice post thou, simple and to the point.
Interesting.
The WTF should be an international measurement unit.
The problem isn’t writing crap. Your own style change, that’s all. You improve.
The problem is when you feel depressed because your boss told you to rewrite everything, because in that moment you’re not aware of the crap you wrote. Gotta learn fast!
Anyway, I don’t say my past lines of code is “crap”: I just see them as milestones of my coding skill progress :D
HAHA Love this!