Shaving Bytes on JavaScript Conditionals

By  on  

Whenever you work with JavaScript code, it's as though there's always a shorter way to code something.  You thought that a code set was basic until you found out that something was basic...er.  One of those code shortcuts can be found with conditions, specifically short if clauses.

A typical short if clause would look something like this:

if(callback) {
	callback();
}

Oddly enough this conditional can be made shorter:

callback && callback();

The && is less code than the if(){}; of course only by a few characters but does the same job. You could argue that readability suffers but that's up to individual developers.

Recent Features

  • By
    Chris Coyier’s Favorite CodePen Demos

    David asked me if I'd be up for a guest post picking out some of my favorite Pens from CodePen. A daunting task! There are so many! I managed to pick a few though that have blown me away over the past few months. If you...

  • By
    Designing for Simplicity

    Before we get started, it's worth me spending a brief moment introducing myself to you. My name is Mark (or @integralist if Twitter happens to be your communication tool of choice) and I currently work for BBC News in London England as a principal engineer/tech...

Incredible Demos

  • By
    Introducing MooTools ScrollSpy

    I've been excited to release this plugin for a long time. MooTools ScrollSpy is a unique but simple MooTools plugin that listens to page scrolling and fires events based on where the user has scrolled to in the page. Now you can fire specific...

  • By
    9 Incredible CodePen Demos

    CodePen is a treasure trove of incredible demos harnessing the power of client side languages.   The client side is always limited by what browsers provide us but the creativity and cleverness of developers always pushes the boundaries of what we think the front end can do.  Thanks to CSS...

Discussion

  1. It’s worth noting that JS minifiers like Google’s Closure Compiler will do this for you, so the first option is probably better so you get the readability without sacrificing performance. The Closure Compiler outputs it as this:

    callback&&callback();

    http://closure-compiler.appspot.com/home

  2. Herbut

    and also jshint might shout about the shorter version (depending on the settings of course).

  3. It’s bad practice though because the code is hard to maintain, debug and extend. I could write a whole blog on why doing this is bad. I see zero benefits.

  4. Agree with comments above. I recently realized that there is no benefits of having expressions in my code so changed jshint settings and now it disallows to use them.

    IMO the expression below is pretty readable and it also takes one line:
    if (callback) callback();

  5. Agree with the “bad practice” comments.

    Sometimes you seem to post stuff just for the sake of it, or to impress beginners.

    • I appreciate your honesty but impressing people isn’t something that entertains me.

  6. Ana

    What if I also need to have an else branch?

    • There’s only “if”, I suppose. Otherwise it’s something like:

      callback ? callback() : otherThing();
      
  7. While I agree with people’s comments on code readability, I still appreciate posts like this.
    I’ve come across the ‘callback && callback();’ syntax before and had to look up wtf was going on. Had I read this post earlier, I would’ve known :)

  8. Sean

    @Dan i agree with you, posts like this are handy so you understand when you come across it in a project. Sadly, this is clearly lost on a couple of the previous commenters who already know everything there is to know.

  9. What setting will make jsHint happy?

  10. Readability is important, but for those who like to hyper-optimize their code, this is a great tip.

Wrap your code in <pre class="{language}"></pre> tags, link to a GitHub gist, JSFiddle fiddle, or CodePen pen to embed!